feat(art): add art funny-cake#22
Merged
Merged
Conversation
mr150
reviewed
May 4, 2026
| <div class="Ps-a B10p L0 W100p H20p Bdrd50p Bgc-$cakeGreen"> | ||
| <!-- Beads --> | ||
| <div class="Ps-a T50p L0 -Sz100p"> | ||
| <div class="<%= css.bead %> T-10p L1p W6p"></div> |
Contributor
There was a problem hiding this comment.
Может попробовать как-то в цикле вывести эти элементы, чтобы меньше бойлерплейта было? Вроде есть паттерн по расположению и размеру
Collaborator
Author
There was a problem hiding this comment.
Исправил. Я даже и не заметил. Круто.
mr150
requested changes
May 4, 2026
mr150
reviewed
May 5, 2026
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="<%= css.creamY %> T15p L72p W30p"> |
Contributor
There was a problem hiding this comment.
Эту часть тоже можно в цикле сделать
mr150
requested changes
May 5, 2026
mr150
reviewed
May 7, 2026
| creamY: 'Ps-a Apcr2/1 Bdrd50p Bgc-$cakeYellow Ov-h' | ||
| creamWhite: 'Ps-a -Sz100p Bdrd50p Bgc-$cakeWhite', | ||
| creamYellow: 'Ps-a Apcr2/1 Bdrd50p Bgc-$cakeYellow Ov-h', | ||
| leftBeads: ['T-10p L1p W6p', 'T0p L3p W8p', 'T16p L7p W10p', 'T28p L13p W12p', 'T38p L22p W15p', 'T45p L34p W18p'], |
Contributor
There was a problem hiding this comment.
Массивы с классами лучше в отдельный словарь выносить
mr150
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.